notif: On Android, use org name instead of URL as notif group summary #2136
+150
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zulip Server 8 (FL 234) started sending realmName in the FCM payload: zulip/zulip@a018f2611 So, we try to use the realm name from the account first, then fallback to notification data, and then finally fallback to displaying the realm URL. Fixes: zulip#570
Member
Author
|
Screenshots:
|
rajveermalviya
added
the
maintainer review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zulip Server 8 (FL 234) started sending realmName in the FCM payload:
zulip/zulip@a018f2611
So, we try to use the realm name from the account first, then fallback to notification data, and then finally fallback to displaying the realm URL.
Fixes: #570